Prototype pretty colors #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we could make our own, scoped down JSX component, since there's a limited amount of stuff we're transforming ... and I do want to add some inner HTML to places where we embed logs -- e.g., make signatures into clickable links to the explorer / workbench txn view automatically ... |
|
added DOMPurify in this PR coupled with a "don't use hot wallets with a hella bag in workbench cause it's meant to more or less sign everything automatically" might be ok? 🤷♂️ I'm equally worried about npm module compromise, long term we'll probably want to mirror our own |
|
this would probably be useful for anchor log fanciness as well ... |
2 tasks
|
OK! tests passing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to give a whirl at getting pretty colors from Amman output working, this is pretty cool, although I don't love that
dangerouslySetInnerHTML... def a potential security concern if the app can sign ... so might not be worth it but I wanted to POC itbefore:
after: